feat(natu): detect redundant let expressions

2026-10-04 21:23:35 -04:00
parent c91094234f
commit 3e9295134e
6 changed files with 183 additions and 13 deletions
--- a/src/dotfiles/registry/validation.nix
+++ b/src/dotfiles/registry/validation.nix
@@ -3,17 +3,6 @@
  lib,
 }:
 let
-  assertValid =
-    data:
-    let
-      assertions = validationAssertions data;
-      failures = lib.filter (assertion: !assertion.assertion) assertions;
-    in
-    assert lib.assertMsg (lib.all (assertion: assertion.assertion) assertions) (
-      lib.concatMapStringsSep "\n" (assertion: assertion.message) failures
-    );
-    data;
-
  validationAssertions =
    data:
    lib.concatLists (
@@ -41,4 +30,12 @@ let
      ) data
    );
 in
-assertValid
+data:
+let
+  assertions = validationAssertions data;
+  failures = lib.filter (assertion: !assertion.assertion) assertions;
+in
+assert lib.assertMsg (lib.all (assertion: assertion.assertion) assertions) (
+  lib.concatMapStringsSep "\n" (assertion: assertion.message) failures
+);
+data