From a97a409c8e26430c1e0d2514ea9a497e8c97d5dd Mon Sep 17 00:00:00 2001
From: alexion <contact@alexion.dev>
Date: Mon, 19 Oct 2026 23:28:54 -0400
Subject: [PATCH] refactor(nixos): inline RomM secret names

---
 configs/nixos/guests/romm.nix | 36 ++++++++++++++++++-----------------
 1 file changed, 19 insertions(+), 17 deletions(-)

diff --git a/configs/nixos/guests/romm.nix b/configs/nixos/guests/romm.nix
index ca424e0..7a05853 100644
--- a/configs/nixos/guests/romm.nix
+++ b/configs/nixos/guests/romm.nix
@@ -7,14 +7,6 @@ let
   cfg = config.guests.romm;
   rommUid = config.registry."stable-uid".${config.networking.hostName}.romm;
   redisUid = config.registry."stable-uid".${config.networking.hostName}."redis-romm";
-  secrets = {
-    igdbClientId = "services/romm/igdb/client-id";
-    igdbClientSecret = "services/romm/igdb/client-secret";
-    retroAchievementsApiKey = "services/romm/retroachievements/api-key";
-    screenScraperUser = "services/romm/screenscraper/user";
-    screenScraperPassword = "services/romm/screenscraper/password";
-    steamGridDbApiKey = "services/romm/steamgriddb/api-key";
-  };
 in
 {
   options.guests.romm = {
@@ -158,21 +150,31 @@ in
       };
     };
 
-    sops.secrets = lib.genAttrs (builtins.attrValues secrets) (_: {
-      sopsFile = ../secrets + "/${config.networking.hostName}.yaml";
-    });
+    sops.secrets =
+      lib.genAttrs
+        [
+          "services/romm/igdb/client-id"
+          "services/romm/igdb/client-secret"
+          "services/romm/retroachievements/api-key"
+          "services/romm/screenscraper/user"
+          "services/romm/screenscraper/password"
+          "services/romm/steamgriddb/api-key"
+        ]
+        (_: {
+          sopsFile = ../secrets + "/${config.networking.hostName}.yaml";
+        });
 
     sops.templates."romm.env" = {
       owner = "root";
       group = "storage";
       mode = "0440";
       content = ''
-        IGDB_CLIENT_ID=${config.sops.placeholder.${secrets.igdbClientId}}
-        IGDB_CLIENT_SECRET=${config.sops.placeholder.${secrets.igdbClientSecret}}
-        SCREENSCRAPER_USER=${config.sops.placeholder.${secrets.screenScraperUser}}
-        SCREENSCRAPER_PASSWORD=${config.sops.placeholder.${secrets.screenScraperPassword}}
-        RETROACHIEVEMENTS_API_KEY=${config.sops.placeholder.${secrets.retroAchievementsApiKey}}
-        STEAMGRIDDB_API_KEY=${config.sops.placeholder.${secrets.steamGridDbApiKey}}
+        IGDB_CLIENT_ID=${config.sops.placeholder."services/romm/igdb/client-id"}
+        IGDB_CLIENT_SECRET=${config.sops.placeholder."services/romm/igdb/client-secret"}
+        SCREENSCRAPER_USER=${config.sops.placeholder."services/romm/screenscraper/user"}
+        SCREENSCRAPER_PASSWORD=${config.sops.placeholder."services/romm/screenscraper/password"}
+        RETROACHIEVEMENTS_API_KEY=${config.sops.placeholder."services/romm/retroachievements/api-key"}
+        STEAMGRIDDB_API_KEY=${config.sops.placeholder."services/romm/steamgriddb/api-key"}
       '';
     };
   };