refactor(dotfiles): separate registry validation

src/dotfiles/registry.nix

@@ -20,14 +20,12 @@ let
       ];
     }).config;
 
-  data = validate (
-    lib.mapAttrs (
-      registryName: _registry:
-      lib.mapAttrs (hostName: host: host.config.registry.${registryName}.${hostName} or { }) hosts
-    ) definitions
-  );
-
   validate = import ./registry/validation.nix { inherit definitions lib; };
+
+  data = lib.mapAttrs (
+    registryName: _registry:
+    lib.mapAttrs (hostName: host: host.config.registry.${registryName}.${hostName} or { }) hosts
+  ) definitions;
 in
 {
   types = lib.mapAttrs (_name: definition: definition.type) definitions;
@@ -46,13 +44,16 @@ in
     ) definitions;
   };
 
-  collected = data // {
+  collected =
-    join =
+    assert validate data;
-      host: entry:
+    data
-      lib.filterAttrs (_name: value: value != null) (
+    // {
-        lib.mapAttrs (
+      join =
-          registryName: _registry: (data.${registryName}.${host} or { }).${entry} or null
+        host: entry:
-        ) definitions
+        lib.filterAttrs (_name: value: value != null) (
-      );
+          lib.mapAttrs (
-  };
+            registryName: _registry: (data.${registryName}.${host} or { }).${entry} or null
+          ) definitions
+        );
+    };
 }

src/dotfiles/registry/validation.nix

@@ -3,17 +3,7 @@
   lib,
 }:
 let
-  assertValid =
+  # NOLINT(single_use_binding)
-    data:
-    let
-      assertions = validationAssertions data;
-      failures = lib.filter (assertion: !assertion.assertion) assertions;
-    in
-    assert lib.assertMsg (lib.all (assertion: assertion.assertion) assertions) (
-      lib.concatMapStringsSep "\n" (assertion: assertion.message) failures
-    );
-    data;
-
   validationAssertions =
     data:
     lib.concatLists (
@@ -29,6 +19,7 @@ let
       ) definitions
     );
 
+  # NOLINT(single_use_binding)
   flattenRegistryEntries =
     registryName: data:
     lib.concatLists (
@@ -41,4 +32,12 @@ let
       ) data
     );
 in
-assertValid
+data:
+let
+  assertions = validationAssertions data;
+in
+lib.assertMsg (lib.all (assertion: assertion.assertion) assertions) (
+  lib.concatMapStringsSep "\n" (assertion: assertion.message) (
+    lib.filter (assertion: !assertion.assertion) assertions
+  )
+)