refactor(dotfiles): clarify registry validation

AGENTS.md

@@ -110,6 +110,8 @@
   Use `git -C <repository-root>` or top-anchored pathspecs for repository-wide history searches.
 - A `**/*.nix` Git pathspec does not include Nix files directly in its starting directory.
   Include both `*.nix` and `**/*.nix`, or use a recursive `*.nix` pathspec, when linting every Nix file.
+- Nix `let` bindings are recursive; their source order does not determine binding availability.
+  Treat Natu `let_order` as a readability rule, not an evaluation dependency.
 - Ariadne extraction must preserve the game-root season prefix for archived source.
   Different game installs can contain compiled scripts with the same internal path.
 - Clew owns Ren'Py extraction, preparation, and compiled-script AST export. Ariadne owns analysis over Clew-produced data.

src/dotfiles/registry.nix

@@ -19,7 +19,7 @@ let
       ];
     }).config;
 
-  validate = import ./registry/validation.nix { inherit definitions lib; };
+  validation = import ./registry/validation.nix { inherit data definitions lib; };
 
   data = lib.mapAttrs (
     registryName: _registry:
@@ -44,7 +44,7 @@ in
   };
 
   collected =
-    assert validate data;
+    assert validation;
     data
     // {
       join =

src/dotfiles/registry/validation.nix

@@ -1,40 +1,34 @@
 {
+  data,
   definitions,
   lib,
 }:
 let
-  validationAssertions =
+  checkResults = lib.concatLists (
-    data:
+    lib.mapAttrsToList (
+      registryName: definition:
+      map (check: {
+        assertion = check.assertion (entriesForRegistry registryName);
+        inherit (check) message;
+      }) definition.checks
+    ) definitions
+  );
+
+  entriesForRegistry =
+    registryName:
     lib.concatLists (
-      lib.mapAttrsToList (
+      lib.mapAttrsToList (host: entries: entriesForHost registryName host entries) data.${registryName}
-        registryName: registry:
-        let
-          entries = flattenRegistryEntries registryName data.${registryName};
-        in
-        map (check: {
-          assertion = check.assertion entries;
-          inherit (check) message;
-        }) registry.checks
-      ) definitions
     );
 
-  flattenRegistryEntries =
+  entriesForHost =
-    registryName: data:
+    registryName: host: entries:
-    lib.concatLists (
+    lib.mapAttrsToList (entry: value: {
-      lib.mapAttrsToList (
+      path = "registry.${registryName}.${host}.${entry}";
-        host: entries:
+      inherit host entry value;
-        lib.mapAttrsToList (entry: value: {
+    }) entries;
-          path = "registry.${registryName}.${host}.${entry}";
+
-          inherit host entry value;
+  failures = lib.filter (result: !result.assertion) checkResults;
-        }) entries
-      ) data
-    );
 in
-data:
+lib.assertMsg (lib.all (result: result.assertion) checkResults) (
-let
+  lib.concatMapStringsSep "\n" (result: result.message) failures
-  assertions = validationAssertions data;
-  failures = lib.filter (assertion: !assertion.assertion) assertions;
-in
-lib.assertMsg (lib.all (assertion: assertion.assertion) assertions) (
-  lib.concatMapStringsSep "\n" (assertion: assertion.message) failures
 )