No way to resolve/unresolve review conversations #39
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What I ran into
After answering a batch of inline review comments, the natural next step is to resolve the threads I'd addressed.
gitea-axi has no command or flag for resolving (or unresolving) a review conversation, so there was no way to close out the threads from the CLI.
Real gap, but SDK-blocked
Real gap: no
resolve/unresolveverb exists anywhere in the dispatch (src/commands/pr.tsprCommand).Worth flagging that it may need more than a thin command, though.
The pinned gitea-js review surface is:
Dismiss/undismiss act on a whole review, not on a single conversation, and there is no resolve-conversation method in the SDK.
So resolving a thread by comment id would need a raw request against Gitea's REST API rather than an existing gitea-js call.
Recommendation
Two-step, depending on appetite:
pr resolve <comment-id>/pr unresolve <comment-id>wrapping it (this depends on surfacing commentidfirst — see the review-comment fields issue).gitea-axi apiissue), which resolve could be built on until the SDK gains the method.Lower priority than reading anchors and posting inline comments, but it's the missing bookend of the review workflow.