alexion/dev
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(copyparty): simplify module helpers #182

Merged
alexion merged 1 commits from refactor/copyparty-let-cleanup into main 2026-10-13 21:14:44 -04:00
Conversation 0 Commits 1 Files Changed 6 +226 -200
alexion commented 2026-10-12 12:28:56 -04:00
Owner
Copy Link

Summary

  • Move Copyparty config rendering into configs/nixos/lib/copyparty-config.nix.
  • Keep the service module focused on options and systemd wiring.
  • Inline the one-use Copyparty volume option type into the volumes option.
  • Type volume paths as external runtime paths.
  • Replace the manual Coreutils path with lib.getExe' pkgs.coreutils "tr".

Verification

  • nix build --no-link '.#nixosConfigurations.pikachu.config.system.build.toplevel'
  • nix run .#fix
  • bazel run //src/natu:natu -- configs/nixos/modules/services/copyparty.nix configs/nixos/lib/copyparty-config.nix
  • Evaluated Copyparty ExecStartPre and inspected the generated config script.
## Summary - Move Copyparty config rendering into `configs/nixos/lib/copyparty-config.nix`. - Keep the service module focused on options and systemd wiring. - Inline the one-use Copyparty volume option type into the `volumes` option. - Type volume paths as external runtime paths. - Replace the manual Coreutils path with `lib.getExe' pkgs.coreutils "tr"`. ## Verification - `nix build --no-link '.#nixosConfigurations.pikachu.config.system.build.toplevel'` - `nix run .#fix` - `bazel run //src/natu:natu -- configs/nixos/modules/services/copyparty.nix configs/nixos/lib/copyparty-config.nix` - Evaluated Copyparty `ExecStartPre` and inspected the generated config script.
alexion added 1 commit 2026-10-13 20:33:28 -04:00
refactor(copyparty): separate deployment and service policy 8462b3a5a8 
Move Copyparty rendering into shared dotfiles utilities, keep guest wiring focused on host/container plumbing, and let the service module derive effective volume policy.
alexion force-pushed refactor/copyparty-let-cleanup from 81174a5ad6 to 8462b3a5a8 2026-10-13 20:33:28 -04:00 Compare
alexion merged commit 8462b3a5a8 into main 2026-10-13 21:14:44 -04:00
alexion deleted branch refactor/copyparty-let-cleanup 2026-10-13 21:14:44 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
alexion
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: alexion/dev#182
Delete Branch "refactor/copyparty-let-cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?