alexion/dev
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(nixos): address Nix review findings #183

Closed
alexion wants to merge 1 commits from fix/nix-review-findings into main
pull from: fix/nix-review-findings
merge into: alexion:main
Conversation 0 Commits 1 Files Changed 13 +215 -94
alexion commented 2026-10-13 21:44:07 -04:00
Owner
Copy Link

Summary

  • render Palworld credentials through PalWorldSettings.ini while preserving existing settings
  • remove deprecated RCON configuration, unsafe public-address wiring, and discouraged startup flags
  • harden generated commands, service identifiers, and host module composition
  • codify the reviewed Nix and flake conventions

Verification

  • nix run .#fix
  • Natu on every modified Nix file
  • evaluate all NixOS system derivations
  • smoke-test Palworld settings rendering and Fish backup path handling
  • nix flake check --no-build
## Summary - render Palworld credentials through `PalWorldSettings.ini` while preserving existing settings - remove deprecated RCON configuration, unsafe public-address wiring, and discouraged startup flags - harden generated commands, service identifiers, and host module composition - codify the reviewed Nix and flake conventions ## Verification - `nix run .#fix` - Natu on every modified Nix file - evaluate all NixOS system derivations - smoke-test Palworld settings rendering and Fish backup path handling - `nix flake check --no-build`
alexion added 1 commit 2026-10-13 21:44:08 -04:00
fix(nixos): address Nix review findings 66efae302f 
Render Palworld secrets through its documented settings file and remove stale RCON configuration.

Harden generated commands, centralize shared modules, and codify the reviewed Nix conventions.
alexion closed this pull request 2026-10-13 21:46:32 -04:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
alexion
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: alexion/dev#183
Delete Branch "fix/nix-review-findings"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?