alexion/dotfiles
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(desktop): add the Waybar status bar (task 0023) #15

Merged
alexion merged 4 commits from task-0023-waybar-status-bar into main 2026-07-22 15:28:13 -04:00
Conversation 0 Commits 4 Files Changed 6 +203 -4
alexion commented 2026-07-22 12:04:14 -04:00
Owner
Copy Link

Task: .claude/tasks/0023-waybar-status-bar.md

Summary

Adds a Waybar status bar to the desktop group, enabled through the aggregator at default priority.
One top bar shows workspaces with per-application icons (mapped from window class), a clock, MPRIS media controls, audio volume, network, battery, and a do-not-disturb toggle.
No overview/exposé plugin is used.
The bar runs as a home-manager systemd user service bound to graphical-session.target, which uwsm activates.

Deviations from the plan:

  • PipeWire added beyond the plan. The task asked only for the bar's audio widget, but nothing in the epic provisions an audio server and a wireplumber widget over a machine with no running sink is inert. A small modules/desktop/audio.nix enables PipeWire (ALSA + Pulse shims, rtkit) under its own modules.desktop.audio.enable. It is a distinct concern that could be split into its own task — flagged for you to keep or separate.
  • Do-not-disturb depends on mako (task 0025). The custom/dnd widget shells out to makoctl; until that daemon lands it degrades to "notifications on" rather than erroring, and reflects real state the moment mako runs.
  • MPRIS controls made explicit. Play-pause on click, next/previous on scroll, rather than relying on Waybar's implicit default.

nix flake check passes (neogaia builds green). The rendered bar, MPRIS, and audio widgets can only be exercised in a live Wayland session on neogaia.

Review

Risk

Overall: Medium

  • Blast radius: Medium — two new modules plus two aggregator enables turn audio/waybar on for every host in the desktop group, though contained to that group.
  • Reversibility: Low — additive new files and toggleable enables, no migrations, deletions, or schema/API changes.
  • Test coverage: Medium — nix flake check builds green but the bar's runtime behavior (shell scripts, glyphs, dispatchers) is unexercised, failing only at login if wrong.
  • Sensitive domain: Medium — touches security.rtkit.enable (realtime-priority scheduling) and PipeWire audio permissions.
  • Size & complexity: Medium — ~135 lines across three files with embedded shell scripts and a fromJSON glyph trick, no tangled control flow.
  • Runtime criticality: Medium — desktop tooling, not production, but audio and the status bar are user-facing session infrastructure whose failure is visible at login.

Unaddressed findings

  • Spec (scope creep, kept by design): modules/desktop/audio.nix / PipeWire is not requested by the task or the parent spec's Components list. Kept because the audio widget is inert without a sink; documented above so it can be split out later if preferred.
  • Standards (judgement call, not actioned): the ${pkgs.X}/bin/… interpolations and format-icons glyph arrays recur across widgets and scripts — the reviewer judged this within house style (matching hyprland.nix) and not worth extracting.

— Claude

Task: `.claude/tasks/0023-waybar-status-bar.md` ## Summary Adds a Waybar status bar to the desktop group, enabled through the aggregator at default priority. One top bar shows workspaces with per-application icons (mapped from window class), a clock, MPRIS media controls, audio volume, network, battery, and a do-not-disturb toggle. No overview/exposé plugin is used. The bar runs as a home-manager systemd user service bound to `graphical-session.target`, which uwsm activates. Deviations from the plan: - **PipeWire added beyond the plan.** The task asked only for the bar's audio *widget*, but nothing in the epic provisions an audio server and a `wireplumber` widget over a machine with no running sink is inert. A small `modules/desktop/audio.nix` enables PipeWire (ALSA + Pulse shims, rtkit) under its own `modules.desktop.audio.enable`. It is a distinct concern that could be split into its own task — flagged for you to keep or separate. - **Do-not-disturb depends on mako (task 0025).** The `custom/dnd` widget shells out to `makoctl`; until that daemon lands it degrades to "notifications on" rather than erroring, and reflects real state the moment mako runs. - **MPRIS controls made explicit.** Play-pause on click, next/previous on scroll, rather than relying on Waybar's implicit default. `nix flake check` passes (neogaia builds green). The rendered bar, MPRIS, and audio widgets can only be exercised in a live Wayland session on neogaia. ## Review ### Risk **Overall: Medium** - Blast radius: Medium — two new modules plus two aggregator enables turn audio/waybar on for every host in the desktop group, though contained to that group. - Reversibility: Low — additive new files and toggleable enables, no migrations, deletions, or schema/API changes. - Test coverage: Medium — `nix flake check` builds green but the bar's runtime behavior (shell scripts, glyphs, dispatchers) is unexercised, failing only at login if wrong. - Sensitive domain: Medium — touches `security.rtkit.enable` (realtime-priority scheduling) and PipeWire audio permissions. - Size & complexity: Medium — ~135 lines across three files with embedded shell scripts and a `fromJSON` glyph trick, no tangled control flow. - Runtime criticality: Medium — desktop tooling, not production, but audio and the status bar are user-facing session infrastructure whose failure is visible at login. ### Unaddressed findings - **Spec (scope creep, kept by design):** `modules/desktop/audio.nix` / PipeWire is not requested by the task or the parent spec's Components list. Kept because the audio widget is inert without a sink; documented above so it can be split out later if preferred. - **Standards (judgement call, not actioned):** the `${pkgs.X}/bin/…` interpolations and `format-icons` glyph arrays recur across widgets and scripts — the reviewer judged this within house style (matching `hyprland.nix`) and not worth extracting. — Claude
alexion added 1 commit 2026-07-22 12:04:15 -04:00
feat(desktop): add the Waybar status bar (task 0023) b21b4ff77e 
Add a Waybar module to the desktop group, enabled through the aggregator,
showing workspaces with per-application icons plus a clock, MPRIS media
controls, audio, network, battery, and a do-not-disturb toggle.

The do-not-disturb widget drives mako's dnd mode and degrades gracefully
until the notifications module lands. Module glyphs are Nerd Font codepoints
decoded through JSON, backed by a system symbols font.

Add a PipeWire audio server so the bar's volume widget has a running sink to
read and drive.
alexion added 1 commit 2026-07-22 15:20:35 -04:00
fix(desktop): highlight the current day in the Waybar calendar ba881998bc
alexion added 1 commit 2026-07-22 15:25:52 -04:00
feat(desktop): bind the hardware volume and media keys 5a7593a793
alexion added 1 commit 2026-07-22 15:27:23 -04:00
docs: require a Waybar icon mapping for new GUI apps 10e68957b1
alexion merged commit 10e68957b1 into main 2026-07-22 15:28:13 -04:00
alexion deleted branch task-0023-waybar-status-bar 2026-07-22 15:28:13 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
alexion
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: alexion/dotfiles#15
Delete Branch "task-0023-waybar-status-bar"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?