fix(neogaia): replace guessed hardware detection with a real scan (task 0017) #2
Reference in New Issue
Block a user
Delete Branch "task-0017-hardware-detection-refresh"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Task:
.claude/tasks/0017-hardware-detection-refresh.mdhosts/neogaia/hardware-configuration.nixwas written before this machine ran NixOS, as an educated guess at what a Dell XPS 13 9380 needs, and said so in its header.Its contents now come from
nixos-generate-config --show-hardware-configon the running machine.The guess turned out to be wider than the measurement rather than narrower.
It named
thunderbolt,usb_storage, andsd_mod, none of which the scan reports, and omittedrtsx_pci_sdmmcfor the card reader.Nothing needed to reach the root device was missing, so the guess was adequate — it just was not accurate.
sd_modsurvives in the resolved list regardless, supplied by nixpkgs' defaults;thunderboltandusb_storagegenuinely leave the initrd, and matter only for booting from external media.Deviations
Two lines were dropped from the scan beyond the filesystem and swap declarations the task named.
boot.initrd.luks.devices."cryptroot".device— derived byhosts/neogaia/disk.nix, which already states that it owns this. Keeping it would create the same duplicate definition the task drops the filesystems to avoid.hardware.cpu.intel.updateMicrocode— outside the three things the task keeps, andnixos-hardwaresupplies it.Both were verified rather than assumed: after the change the LUKS device, all four filesystems, and microcode all still resolve, the last still
true.Review
Risk
Overall: HIGH
nix flake checkprovesrcises whether the initrd can unlock LUKS andmount rootUnaddressed findings
tool-narration. The ban covers narrating another placeholder example names that same generator,
and the task asks the file to state what it hold
The reviewer's other standards finding — a headeattributes, which the comment convention forbidsas a feature inventory — is fixed in the diff. The spec axis returned no findings.
Not verified by a boot
nix flake checkproves this evaluates and builoduces can unlock LUKS and mount root.That needs a
nixos-rebuild switchand a rebootn available at the bootloader as the fallback.— Claude